search

james-proxy / james

Web Debugging Proxy Application
1.42k stars 125 forks source link

Release of version 2.1.0 #379

Closed nerdbeere closed 5 years ago

nerdbeere commented 6 years ago

I'd like to release a new version once we merged https://github.com/james-proxy/james-browser-launcher/pull/74 and created a new james-browser-launcher version.

How do you guys feel about this? @mitchhentges @tomitm @jrmykolyn

mitchhentges commented 6 years ago

I remember there being some issues with electron-updater, so I'd want to ensure that we test upgrades from:

Other than that, this sounds awesome so that that crash issue is mitigated :+1:

jrmykolyn commented 6 years ago

Thanks to everyone for bringing me on board as org. member and collaborator.

I haven't been on the team long enough to speak to the electron-related issues that @mitchhentges is referencing (although I've seen them mentioned in other PRs), but, on a personal note, I'd be happy the crash fix go out into the wild.

nerdbeere commented 6 years ago

@mitchhentges not sure if I know how exactly ensure/test this properly

mitchhentges commented 6 years ago

This was one of the problems :thinking:

I'm a little fuzzy now, but there should be docs that explain enough for us to be able to test updates without actually updating real installations in the field (perhaps these?) When I've got time (tomorrow probably) I want to do a pass at updating all of James' dependencies, including electron-*. When I do that, I'll peek through the electron-updater changelog and see what I can find

tomitm commented 6 years ago

Regarding the auto-update issues @mitchhentges is talking about: I don't entirely remember the details, but #358 has some details about rolling back electron-updater to fix a Windows issue.

Looking at electron-updater's changelog, there's been a number of updates since, so it might be safe to update that dependency at this point.

I noted in the 2.0.0 release issue (#355) that auto-update is confirmed to work albeit a bit rough around the edges (otherwise I would've held off), so releasing shouldn't be an issue. :shipit:

mitchhentges commented 6 years ago

We have changed the version of electron-updater since 2.0.0 (to 2.19.0 from 2.16.3), so we'll either want to:

mitchhentges commented 6 years ago

Dependencies have been updated as part of #387, and I'm happy with the bugfixes and perf improvements. I think after release testing we should be "green across the board" for release

mitchhentges commented 5 years ago

Added documentation for running upgrade tests

"Passes upgrade test" checklist:

mitchhentges commented 5 years ago

Having issues testing on mac - you can see the error on sentry

Could not get code signature for running application

🤔 not sure how to work around this yet

mitchhentges commented 5 years ago

I couldn't find a nice way of working around this - @nerdbeere, would you be able to do an upgrade test on Mac? I've got docs available here :smile:

mitchhentges commented 5 years ago

I'm going to do a pre-release build via Travis, so I can get signed builds. If those upgrade from our last pre-release (2.0.0-beta.3) then I'll consider it ready for release :smile:

mitchhentges commented 5 years ago

Release complete! Had an issue with exceptions being triggered when spooling up HTTPs, but I've released v2.1.1 to resolve that