search

james-see / iptcinfo3

iptcinfo working for python 3 finally do pip3 install iptcinfo3
52 stars 31 forks source link

"Marker scan hit start of image data" should not be the WARN #24

Open niwics opened 4 years ago

niwics commented 4 years ago

When parsing JPEG files with no IPTC data, I suppose that the scanning message Marker scan hit start of image data should not be logged as warning, but as info. At least when I use the force=True flag in IPTCInfo constructor (intended for processing files without IPTC data).

Maybe I am missing something, but I don't see the possibility to determine whether my image has IPTC data or not without warnings.

james-see commented 3 years ago

@niwics That depends on what assumptions the package should have re: IPTC data present in images it is scanning. I feel like if force=True, it should just change it to INFO instead of WARNING, since you are basically overriding the traditional approach of getting data about the image being loaded.

niwics commented 3 years ago

I agree with that - when I use the flag force=True, I assume that no IPTC data are there so INFO log level is appropriate.

james-see commented 1 year ago

minor issue compared to supporting latest IPTC tags that still need work. closing for now unless sponsored.