search

james-trayford / strauss

Sonification Tools and Resources for Analysis Using Sound Synthesis
Apache License 2.0
33 stars 4 forks source link

Angle naming #12

Closed james-trayford closed 9 months ago

james-trayford commented 9 months ago

Update default angle names to azimuth and polar in place of phi and theta respectively - This is to avoid the confusion between mathematical and engineering conventions on the use of spherical coordinates (which swap meanings of phi and theta).

This is made the default in examples, but phi and theta should still work the same way as before, just the Source object will raise an error if fed some combination including both phi and azimuth or theta and polar. We threaten to deprecate the old names too.

added NewAngleNaming.ipynb test to tests/pre-merge/ to demo this.

james-trayford commented 9 months ago

OK great, I've removed the pre-merge test so can merge now