Ready for review

[james-wills]

@codepathreview @codepath My submission is ready for review!

My gifs were too large to upload to imgur so I provided links to them on giphy instead of embedding them directly in the README.

[nesquena]

James,

Nice work. A few specific notes after checking out the code:

• Be sure to go back and re-read how the alternate resources system works. The idea is you want to avoid use of runtime landscape checks and use alternate layout files in a res/layout-landscape folder (or other resource folders) so the system automatically manages this for you. There's no need to do these checks at runtime in your activities when you leverage this system.
• Good to see you playing around with RelativeLayout here. Be sure to fully constrain your views in a RelativeLayout by applying rules to 2-3 edges of each view. See this guide on optimizing layouts to learn more about how to keep your screens fast.
• Take a look at how to better organizing your source files. See if you want to try organizing by application feature rather than category. Be sure to put your activities into a sub-package.
• Avoid putting anything related to views and Context in your models as this is a violation of separation of concerns. Keep that in separate presenter objects or inside the adapter itself.
• Always good to implement some handling of the onFailure during network calls. Ideally displaying a message on screen indicating that the load failed and to please try again. Worst case, at least display a snackbar allowing them to try again.
• Good job using the ViewHolder pattern to improve performance of photos ListView. Be sure to make sure you understand view recycling and the viewholder and why are so important to creating performing lists.
• Good to see you using the YouTubePlayerView. Be sure to read more about VideoView and related libraries on that guide to make sure you understand your options for non-Youtube videos.
• Be sure to try using the ButterKnife library annotations for reducing view boilerplate substantially.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to leveraging resources, multiple configurations, optimizing lists, networking, working with APIs and loading remote images.

The next assignment will introduce new concepts such as accepting user input, working with the app bar, handling events for views and navigating between activities among other additional concepts.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply back here or or email us support@codepath.com.