jamesamcl / pysbolgraph

Simple native Python library to read and write Synthetic Biology Open Language (SBOL) files 🐍
http://sbolstandard.org
BSD 2-Clause "Simplified" License
4 stars 5 forks source link

Add support for SBOL version 1 #7

Open jamesamcl opened 5 years ago

jamesamcl commented 5 years ago

Version 1 of the SBOL specification is still used by tools such as Benchling. Ideally, it would be possible to convert to and from SBOL version 1 as supported by libSBOLj.

vaniisgh commented 5 years ago

Hey ! Noticed that while creating the defining components ,sequences or modules version is specified as 1 , should it not be 2 ? Also , the validation of the query is done using SBOL Version 2.2.1 . Should this be checked as well ?

jamesamcl commented 5 years ago

Hi, there are two "versions": one is the version of the specification (e.g., 2.2.1), and one is the optional version of objects in the SBOL data model (usually just an integer like 1). The two concepts are not related.

vaniisgh commented 5 years ago

Thanks ! I didn't realise the data model was optional . Thought it was related to specification ! thanks for the clarification .