jamesaoverton / cmi-pb-terminology

CMI-PB Controlled Terminology
0 stars 0 forks source link

Use SQLAlchemy to escape SQL query #21

Closed beckyjackson closed 2 years ago

beckyjackson commented 2 years ago

Resolves #19

beckyjackson commented 2 years ago

@jamesaoverton do the comments (description) need to be escaped? SQLAlchemy is adding quotes around some of them.

jamesaoverton commented 2 years ago

I can see how the comments would cause problems. We can omit them.

beckyjackson commented 2 years ago

Omit the comments from the escaping, or omit them entirely from the output?

jamesaoverton commented 2 years ago

I'm fine with omitting the comments entirely from the generated SQL.

jamesaoverton commented 2 years ago

You showed me the general approach, and I made a couple more changes. Thanks!