jamesblasco / modal_bottom_sheet

Flutter | Create advanced modal bottom sheets. Material, Cupertino or your own style
https://pub.dev/packages/modal_bottom_sheet
MIT License
1.83k stars 461 forks source link

incompatible about 3.10.0 #349

Open Zvirtuey opened 1 year ago

Zvirtuey commented 1 year ago

Flutter 3.10.0 • channel stable • https://github.com/flutter/flutter.git Framework • revision 84a1e904f4 (6 days ago) • 2023-05-09 07:41:44 -0700 Engine • revision d44b5a94c9 Tools • Dart 3.0.0 • DevTools 2.23.1

----------------------------------------------------------------------------------------------->

modal_bottom_sheet-2.1.2/lib/src/material_with_modal_page_route.dart:4:1: Error: 'ModalBottomSheetRoute' is imported from both 'package:flutter/src/material/bottom_sheet.dart' and 'package:modal_bottom_sheet/src/bottom_sheet_route.dart'. import '../modal_bottom_sheet.dart'; ^^^^^^^^^^^^^^^^^^^^^

modal_bottom_sheet-2.1.2/lib/src/bottom_sheets/material_bottom_sheet.dart:28:13: Error: 'ModalBottomSheetRoute' is imported from both 'package:flutter/src/material/bottom_sheet.dart' and 'package:modal_bottom_sheet/src/bottom_sheet_route.dart'. .push(ModalBottomSheetRoute( ^^^^^^^^^^^^^^^^^^^^^

modal_bottom_sheet-2.1.2/lib/src/bottom_sheets/material_bottom_sheet.dart:50:10: Error: A value of type 'Object?' can't be returned from an async function with return type 'Future<T?>'.

modal_bottom_sheet-2.1.2/lib/src/bottom_sheets/bar_bottom_sheet.dart:102:13: Error: 'ModalBottomSheetRoute' is imported from both 'package:flutter/src/material/bottom_sheet.dart' and 'package:modal_bottom_sheet/src/bottom_sheet_route.dart'. .push(ModalBottomSheetRoute( ^^^^^^^^^^^^^^^^^^^^^

modal_bottom_sheet-2.1.2/lib/src/bottom_sheets/bar_bottom_sheet.dart:125:10: Error: A value of type 'Object?' can't be returned from an async function with return type 'Future<T?>'.

TDuffinNTU commented 1 year ago

3.0.0-pre resolved this for me

stcojo commented 1 year ago

I think this library is dead...

TDuffinNTU commented 1 year ago

@stcojo afaik it's being re-written by the same dev, and they're currently taking a hiatus so the pre-release should hopefully be merged when theyre back. If not maybe someone will have to take a look at forking :)

harshitAmar commented 1 year ago

I've fixed it for me and here it is, You can use it by writing modal_bottom_sheet: git: url: https://github.com/harshitAmar/modal_bottom_sheet.git ref: main

thomashrabe commented 1 year ago

@harshitAmar how can I include your 3.10 fix in my project best? I dont understand where to put your fourliner... New to flutter.

Fox520 commented 1 year ago

@thomashrabe

dependencies:
  flutter:
    sdk: flutter
  modal_bottom_sheet: ^3.0.0-pre
vicenterusso commented 1 year ago

Can we expect a new compatible stable release anytime soon? I think i'ts the only "non-stable" package not compatible with latest version in my app.

Is there any open issue to solve for the final 3 release I could help?