search

jamesblasco / modal_bottom_sheet

Flutter | Create advanced modal bottom sheets. Material, Cupertino or your own style
https://pub.dev/packages/modal_bottom_sheet
MIT License
1.83k stars 461 forks source link

[sheet] 1.0.0-pre scrollable.dart SheetState miss devicePixelRatio #364

Closed GenLix closed 10 months ago

GenLix commented 10 months ago

flutter version: 3.13.0

ihadabs commented 10 months ago

same

Failed to build iOS app
Error (Xcode):
../../../../../../../.pub-cache/hosted/pub.dev/sheet-1.0.0-pre/lib/src/scrollable.dar
t:313:7: Error: The non-abstract class 'SheetState' is missing implementations for
these members:

Encountered error while building for device.

flutter --version 
Flutter 3.13.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision efbf63d9c6 (2 days ago) • 2023-08-15 21:05:06 -0500
Engine • revision 1ac611c64e
Tools • Dart 3.1.0 • DevTools 2.25.0
ihadabs commented 10 months ago

@GenLix @Maatteogekko

You can use the following till it's fixed:

sheet:
    git:
        url: https://github.com/ihadabs/sheet.git
saltedpotatos commented 10 months ago

Ive opened PR #365 with changes that mirror the Flutter PR that introduced devicePixelRatio changes.

Maatteogekko commented 10 months ago

This should stay open until a new version with the fix is released, don't you think?

VladSparkco commented 10 months ago

@GenLix @Maatteogekko

You can use the following till it's fixed:

sheet:
    git:
        url: https://github.com/ihadabs/sheet.git

Hi! Where should I add the code?

gibahjoe commented 9 months ago

@GenLix @Maatteogekko You can use the following till it's fixed:

sheet:
    git:
        url: https://github.com/ihadabs/sheet.git

Hi! Where should I add the code?

add it to pubspec