search

jamesblasco / modal_bottom_sheet

Flutter | Create advanced modal bottom sheets. Material, Cupertino or your own style
https://pub.dev/packages/modal_bottom_sheet
MIT License
1.9k stars 477 forks source link

fix(sheet): adapt scrollable.dart to upstream SemanticsNode changes #387

Closed richardshiue closed 8 months ago

richardshiue commented 9 months ago

This PR https://github.com/flutter/flutter/pull/137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible when using flutter version 3.18 and upwards

harryxu commented 9 months ago

Use this PR before merge:

dependency_overrides:
  sheet:
    git:
      url: https://github.com/jamesblasco/modal_bottom_sheet.git
      ref: 8ee20bd36acaeb36996a09ba9d0f9e7059bb49df
      path: sheet
OpenJarvisAI commented 8 months ago

I deprecated this lib

harryxu commented 8 months ago

@OpenJarvisAI Any alternatives?

OpenJarvisAI commented 8 months ago

Don't using it.

OpenJarvisAI commented 8 months ago

@jamesblasco Hi, Can u still clarify sheet and modal_sheet which one to use?

Users are really lack of maintainance back for fast evoling flutter versions.

We can just focus on one single lib to maintain.

jamesblasco commented 8 months ago

Model bottom sheet should be the one to prioritized. It is the one used the most and definitely the one that should be updated more often.

Sheet has more features and it is the one I personally use in my projects so I will be also maintaining it. But I think long term modal bottom sheet will be the one that persists even if it adopts some ideas from the sheet package