search

jamesbowman / openexrpython

OpenEXR bindings for Python
Other
94 stars 35 forks source link

Support for multi-part files #39

Closed bryab closed 4 years ago

bryab commented 4 years ago

Hi there. I needed support for multi-part for a script I was writing, so I decided to do a basic implementation of it here. There is a lot of redundancy now between OutputFile and MultiPartOutputFile. I am not a C++ expert, so let me know what you think the next step should be to make this more usable to others.

I wouldn't suggest merging this in at this point since MultiPartInputFile is not yet implemented, and I am only supporting scanline files. Also, I want to know what you think of my decision not to expose OutputPart, and instead to just let you specify the "part number" in the writePixels method. To support more file types, we will have to add the option to specify the type (scanline or tiled) in the header of each part.

bryab commented 4 years ago

Went ahead and implemented reading too. Still need to support tiles. Also, I'm not sure how to proceed with checking the EXR library version (since multipart requires EXR 2.0)

jamesbowman commented 4 years ago

Merged, thanks a lot