jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
497 stars 50 forks source link

Fix issue for .HasRecyclableDescendant #166

Closed jamescourtney closed 3 years ago

jamescourtney commented 3 years ago

We were falsely traversing things that were not recyclable.

codecov[bot] commented 3 years ago

Codecov Report

Merging #166 (17bfc5f) into master (7134de8) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files         107      107           
  Lines        7619     7619           
  Branches      669      669           
=======================================
  Hits         7119     7119           
  Misses        375      375           
  Partials      125      125           
Impacted Files Coverage Δ
src/FlatSharp/TypeModel/ITypeModelExtensions.cs 98.55% <ø> (ø)
...tSharp/Serialization/DeserializeClassDefinition.cs 98.97% <100.00%> (ø)
src/FlatSharp/TypeModel/UnionTypeModel.cs 97.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7134de8...17bfc5f. Read the comment docs.