search

jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
510 stars 51 forks source link

Compiler Should Not Accept Unquoted Strings in Metadata #186

Closed jamescourtney closed 3 years ago

jamescourtney commented 3 years ago

Currently, FlatSharp accepts this:

table SomeTable (fs_serializer:Lazy) { }

This has been a happy accident until now due to a bug in the grammar, which accepted identifiers (ie, unqouted strings) and even scalars. The "proper" grammar is to require quoted strings:

table SomeTable (fs_serializer:"Lazy") { }

This counts as a breaking change, so it will need to be part of FlatSharp 6, whenever that happens.