jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
510 stars 51 forks source link

More robust spawning of `flatc` with output handling #257

Closed atifaziz closed 2 years ago

atifaziz commented 2 years ago

This PR addresses a number of robustness issues with spawning of flatc and harnessing its output. The changes can be summarised as follows:

All tests were passing locally with these changes.

jamescourtney commented 2 years ago

Thanks for this! I will review later today!

codecov[bot] commented 2 years ago

Codecov Report

Merging #257 (f263635) into master (0fbcaf7) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   95.22%   95.25%   +0.02%     
==========================================
  Files         109      109              
  Lines        7147     7168      +21     
  Branches      672      673       +1     
==========================================
+ Hits         6806     6828      +22     
  Misses        237      237              
+ Partials      104      103       -1     
Impacted Files Coverage Δ
src/FlatSharp.Compiler/FlatSharpCompiler.cs 87.80% <100.00%> (+2.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fbcaf7...f263635. Read the comment docs.

jamescourtney commented 2 years ago

Thanks for your work here. I'll approve and commit pending this test pass.