search

jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
510 stars 51 forks source link

Support nan/inf default values #284

Closed mattico closed 2 years ago

mattico commented 2 years ago

These are allowed in the FlatBuffer schema language.

jamescourtney commented 2 years ago

Thank you for this! I hadn't even considered this. Appreciate you putting together a PR with tests. I'll take a look this weekend.

codecov[bot] commented 2 years ago

Codecov Report

Merging #284 (9123072) into main (8881a32) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   95.63%   95.63%   -0.01%     
==========================================
  Files         113      113              
  Lines        7587     7598      +11     
  Branches      703      706       +3     
==========================================
+ Hits         7256     7266      +10     
  Misses        230      230              
- Partials      101      102       +1
Impacted Files Coverage Δ
...atSharp.Compiler/SchemaModel/PropertyFieldModel.cs 92.69% <100.00%> (+0.38%) :arrow_up:
src/FlatSharp/FlatBufferSerializer.cs 89.00% <0.00%> (-1.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8881a32...9123072. Read the comment docs.