search

jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
497 stars 50 forks source link

Switch serialize #295

Closed jamescourtney closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #295 (2bbf1cd) into main (1d9d224) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   95.66%   95.69%   +0.03%     
==========================================
  Files         114      114              
  Lines        7771     7830      +59     
  Branches      722      731       +9     
==========================================
+ Hits         7434     7493      +59     
  Misses        233      233              
  Partials      104      104
Impacted Files Coverage Δ
src/FlatSharp/TypeModel/TableMemberModel.cs 93.83% <ø> (ø)
src/FlatSharp/TypeModel/TableTypeModel.cs 96.13% <100.00%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d9d224...2bbf1cd. Read the comment docs.

jamescourtney commented 2 years ago

While this does work, it seems that the explosion in code size roughly cancels out the impact of the if statements and microbenchmarks are unimpressed with the change. Closing out, but will keep the branch.