jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
497 stars 50 forks source link

Reduce Code Duplication #313

Closed jamescourtney closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #313 (89a7fbc) into main (1c411cf) will increase coverage by 0.13%. The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   95.75%   95.88%   +0.13%     
==========================================
  Files         114      114              
  Lines        7839     7992     +153     
  Branches      747      761      +14     
==========================================
+ Hits         7506     7663     +157     
+ Misses        229      222       -7     
- Partials      104      107       +3     
Impacted Files Coverage Δ
src/FlatSharp.Compiler/CompileContext.cs 100.00% <ø> (ø)
src/FlatSharp.Runtime/IGeneratedSerializer.cs 100.00% <ø> (ø)
src/FlatSharp.Runtime/ISerializerExtensions.cs 82.35% <ø> (ø)
src/FlatSharp/FlatBufferSerializerOptions.cs 85.71% <ø> (ø)
...latSharp/TypeModel/Vectors/ArrayVectorTypeModel.cs 100.00% <ø> (ø)
...odel/VectorsOfUnion/ArrayVectorOfUnionTypeModel.cs 100.00% <ø> (+11.11%) :arrow_up:
src/FlatSharp.Runtime/TableFieldContext.cs 70.58% <54.54%> (-29.42%) :arrow_down:
...rc/FlatSharp.Runtime/GeneratedSerializerWrapper.cs 84.84% <92.00%> (+0.93%) :arrow_up:
...atSharp.Compiler/SchemaModel/PropertyFieldModel.cs 92.69% <92.27%> (ø)
src/FlatSharp.Compiler/CompilerOptions.cs 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c411cf...89a7fbc. Read the comment docs.

jamescourtney commented 1 year ago

Still need to rationalize what to do about writethrough schemas when used with greedy/greedymutable.