search

jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
497 stars 50 forks source link

Normalize field names by default #326

Closed jamescourtney closed 1 year ago

jamescourtney commented 1 year ago

@joncham and @vvuk -- just FYI I am renaming fs_preserveCasing to fs_literalName, as well as enabling field name normalization by default.

codecov[bot] commented 1 year ago

Codecov Report

Merging #326 (eb03e02) into main (1f0241e) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   95.60%   95.57%   -0.03%     
==========================================
  Files         103      103              
  Lines        7941     7941              
  Branches      735      735              
==========================================
- Hits         7592     7590       -2     
  Misses        244      244              
- Partials      105      107       +2
Impacted Files Coverage Δ
src/FlatSharp.Compiler/MetadataKeys.cs 100.00% <ø> (ø)
src/FlatSharp.Compiler/FlatSharpCompiler.cs 91.82% <100.00%> (ø)
...tSharp.Compiler/SchemaModel/FlatSharpAttributes.cs 100.00% <100.00%> (ø)
src/FlatSharp.Runtime/SpanComparers.cs 84.09% <0.00%> (-2.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f0241e...eb03e02. Read the comment docs.