Codecov Report

Merging #360 (6481985) into main (72a0ecf) will increase coverage by 0.30%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   96.15%   96.46%   +0.30%     
==========================================
  Files         115      114       -1     
  Lines        8742     8687      -55     
  Branches      815      812       -3     
==========================================
- Hits         8406     8380      -26     
+ Misses        230      202      -28     
+ Partials      106      105       -1

Impacted Files	Coverage Δ
...peModel/Vectors/UnityNativeArrayVectorTypeModel.cs	`98.63% <95.00%> (+16.54%)`	:arrow_up:
src/FlatSharp.Runtime/IO/SpanWriterExtensions.cs	`100.00% <100.00%> (ø)`
src/FlatSharp.Runtime/SpanComparers.cs	`84.09% <0.00%> (-2.28%)`	:arrow_down:
src/FlatSharp.UnityPolyfills/NativeArray.cs
...atSharp/Serialization/RoslynSerializerGenerator.cs	`98.33% <0.00%> (+0.18%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72a0ecf...6481985. Read the comment docs.

jamescourtney commented 1 year ago

@joncham for awareness. This is just a few small tweaks after playing around with NativeArray myself. The little endian check is important since we don't want a BE machine to write data in the wrong order. LMK if you have any objections, but it should be pretty straightforward.

joncham commented 1 year ago

Thanks for help on original PR and this cleanup.

jamescourtney / FlatSharp

Improve native array coverage #360

Codecov Report