jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
510 stars 51 forks source link

Refactor exceptions and string concat #420

Closed jamescourtney closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6260caf) 97.31% compared to head (b78e882) 97.01%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420/graphs/tree.svg?width=650&height=150&src=pr&token=6EUECHZGT4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney)](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney) ```diff @@ Coverage Diff @@ ## main #420 +/- ## ========================================== - Coverage 97.31% 97.01% -0.31% ========================================== Files 126 126 Lines 9698 9735 +37 Branches 786 787 +1 ========================================== + Hits 9438 9444 +6 - Misses 169 200 +31 Partials 91 91 ``` | [Files](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney) | Coverage Δ | | |---|---|---| | [...harp.Compiler/SchemaModel/RpcServiceSchemaModel.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5Db21waWxlci9TY2hlbWFNb2RlbC9ScGNTZXJ2aWNlU2NoZW1hTW9kZWwuY3M=) | `98.98% <100.00%> (ø)` | | | [...iler/SchemaModel/StructVectorPropertyFieldModel.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5Db21waWxlci9TY2hlbWFNb2RlbC9TdHJ1Y3RWZWN0b3JQcm9wZXJ0eUZpZWxkTW9kZWwuY3M=) | `96.40% <100.00%> (ø)` | | | [...arp.Compiler/SchemaModel/ValueStructSchemaModel.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5Db21waWxlci9TY2hlbWFNb2RlbC9WYWx1ZVN0cnVjdFNjaGVtYU1vZGVsLmNz) | `94.48% <100.00%> (+0.03%)` | :arrow_up: | | [...harp.Compiler/SchemaModel/ValueUnionSchemaModel.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5Db21waWxlci9TY2hlbWFNb2RlbC9WYWx1ZVVuaW9uU2NoZW1hTW9kZWwuY3M=) | `96.95% <100.00%> (ø)` | | | [src/FlatSharp.Runtime/FlatSharpInternal.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL0ZsYXRTaGFycEludGVybmFsLmNz) | `87.50% <100.00%> (+12.50%)` | :arrow_up: | | [src/FlatSharp.Runtime/IO/InputBufferExtensions.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL0lPL0lucHV0QnVmZmVyRXh0ZW5zaW9ucy5jcw==) | `96.07% <100.00%> (-0.22%)` | :arrow_down: | | [src/FlatSharp.Runtime/IO/SpanWriterExtensions.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL0lPL1NwYW5Xcml0ZXJFeHRlbnNpb25zLmNz) | `95.55% <ø> (ø)` | | | [src/FlatSharp.Runtime/SerializationHelpers.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL1NlcmlhbGl6YXRpb25IZWxwZXJzLmNz) | `93.10% <100.00%> (-0.84%)` | :arrow_down: | | [src/FlatSharp.Runtime/SerializerSettings.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL1NlcmlhbGl6ZXJTZXR0aW5ncy5jcw==) | `97.29% <100.00%> (-2.71%)` | :arrow_down: | | [src/FlatSharp.Runtime/SortedVectorHelpers.cs](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney#diff-c3JjL0ZsYXRTaGFycC5SdW50aW1lL1NvcnRlZFZlY3RvckhlbHBlcnMuY3M=) | `98.80% <100.00%> (-0.60%)` | :arrow_down: | | ... and [24 more](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney). Last update [6260caf...b78e882](https://app.codecov.io/gh/jamescourtney/FlatSharp/pull/420?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Courtney).