jamescourtney / FlatSharp

Fast, idiomatic C# implementation of Flatbuffers
Apache License 2.0
511 stars 51 forks source link

Remove Memory support for everything but byte. #61

Closed jamescourtney closed 4 years ago

jamescourtney commented 4 years ago

Memory support for types other than byte needs to go. For precompiled serializers, this can lead to endianness issues using a precompiled serializer generated on a little-endian system on a big-endian system. This design worked with original versions of FlatSharp when schemas were only compiled at runtime, but that assertion got dropped when the compiler was added, and it's a feature that doesn't provide a lot of value (you can always do your own encoding of... whatever inside a byte array). List and array vectors are unaffected by this change.