search

jamescowens / Gridcoin-Research

Gridcoin-Research
MIT License
2 stars 0 forks source link

Currently CScraperManifest::DeleteManifest(const uint256& nHash) just deletes the map entry #14

Closed jamescowens closed 5 years ago

jamescowens commented 5 years ago

This may lead to a slow memory leak. Should this do more? Destructor?

jamescowens commented 5 years ago

@tomasbrod Can you take a look at this? I am worried this will lead to a slow memory leak. I am not sure just unmapping is good enough.

jamescowens commented 5 years ago

@denravonska looked at this and we are safe because the map is to unique_ptrs, which will go out of scope and call the default destructor on CScraperManifest.