search

jamesdales / IconMapSupport

MIT License
8 stars 1 forks source link

BUG Tooltip broken? #71

Open ASMSU2023 opened 2 months ago

ASMSU2023 commented 2 months ago

When hoovering over tooltip in my map, only a blank box shows suddenly. Noticed same on the website example map. icon map bug

sirsir23333 commented 2 months ago

same here

dontsu87 commented 2 months ago

I am having the same problem of not seeing the tooltips. Also, at the same time some of my custom background layers are not visible. These background layers are using open source xyz tiles, and I have confirmed that none of them have any problems with the source. All of this has happened in the last day or so. What I have noticed since this started happening is that the leaflet credit display at the bottom of the map screen now has a yellow and blue flag-like icon. This is probably due to a change in the specifications of leaflet.js used to draw the map or a bug.

dontsu87 commented 2 months ago

I found a solution to the workaround for the custom basemap not showing up that I posted earlier: it seems that the xyz tile URLs have been changed to forcefully refuse to load without SSL (http without an “s”), so you can work around the problem by rewriting the URLs with SSL.

ASMSU2023 commented 2 months ago

Does anyone know if they will fix this, or let the free version "die", as they have released a pro version?

jamesdales commented 2 months ago

These issues were caused by a patch to solve a security vulnerability. As it's been such a long time since the previous release, to submit the patch I've had to update a number of libraries, including the Power BI API. This has caused a couple of issues. I've now resolved these, and will submit an update to AppSource over the weekend. Microsoft will take another 2 weeks to review and publish the fix - I'm afraid I can't speed that up.

It's not my intention to support the old Icon Map visual going forward, but obviously I don't want existing features breaking.

@dontsu87 I'm afraid I can't do anything about the http links. HTTPS is now enforced for external resources, but it sounds like you've managed to resolve that.

ASMSU2023 commented 2 months ago

Thanks for your reply and effort James! :)

dontsu87 commented 2 months ago

@jamesdales Now I can't imagine POWERBI without your wonderful tools. Thanks for the quick response and improvement. I think this is a desirable change, since it is true that http in general should be blocked.

jjsmackay commented 1 month ago

@jamesdales Thanks for looking into this. Would you consider uploading the fixed version to the old Downloads page? https://icon-map.com/downloads.html

AB2531 commented 3 weeks ago

Hello, @jamesdales Thank you for the patch for fixing this. This has been however more than a month now that the tooltip feature is still broken. Has the patch been refused by Microsoft? Is there a way to roll back to a previous version of Iconmap or other way to fix this?