jamesdolezal / slideflow

Deep learning library for digital pathology, with both Tensorflow and PyTorch support.
https://slideflow.dev
GNU General Public License v3.0
234 stars 39 forks source link

[Documentation] Optimization space documentation missing #308

Closed luiscarm9 closed 10 months ago

luiscarm9 commented 10 months ago

Description

The documentation for the methods sf.util.shallow_search_space() and sf.utils.broad_search_space() needs to be included.

Expected behaviour

In the documentation, these methods are mentioned for parameter optimization. But the parameters and their different usage could be more precise for me.

Environment:

jamesdolezal commented 10 months ago

Thank you for this - the docstrings for these functions are already written (see https://github.com/jamesdolezal/slideflow/blob/master/slideflow/util/smac_utils.py), although our sphinx autodocs did not add these to the docs during build. I will update the autodocs config to include these and re-build the documentation.

luiscarm9 commented 10 months ago

Perfect, thanks for the fast reply. Should I use the Documentation Tag if I find further suggestions?

jamesdolezal commented 10 months ago

Yes, the Documentation tag would be best for tracking these types of issues. Thanks again the feedback!