search

jamesdolezal / slideflow

Deep learning library for digital pathology, with both Tensorflow and PyTorch support.
https://slideflow.dev
GNU General Public License v3.0
234 stars 39 forks source link

Unexpected keyword argument "save_checkpoints" #309

Closed luiscarm9 closed 10 months ago

luiscarm9 commented 10 months ago

The keyword argument "save_checkpoints" set up in the method smac_search is unknown to the training method. If this functionality is intended I think it also needs to be implemented then.

jamesdolezal commented 10 months ago

Thanks for raising this. The save_checkpoints argument is used when using the Tensorflow backend:

https://github.com/jamesdolezal/slideflow/blob/070a34f8924d4c9316e900d1b096861499740bc9/slideflow/model/tensorflow.py#L1623

Although the argument is not used in PyTorch. Rather than remove the argument, let's add feature parity for the PyTorch backend. I'll put out a patch & test in the next couple of days, and include the update in the 2.1.1 release.

jamesdolezal commented 10 months ago

Closed, as a fix was implemented in 0a0ce26