search

jamesej / lyniconanc

Lynicon CMS for ASP.Net Core for .Net Standard 2.0/2.1 and .Net 4.6.1/4.6
http://www.lynicon.com
Other
189 stars 28 forks source link

No validation on lynicon/items JS delete confirmation #10

Closed jimbo8098 closed 5 years ago

jimbo8098 commented 5 years ago

Other than a not null check, no validation is performed on click events performed on the del-link class within LyniconItems.cshtml

image

jamesej commented 5 years ago

Hi thanks for taking the time to report this issue. Can you explain further what validation you would be expecting? We already have confirmation by the user and role checking within the API it calls.

jimbo8098 commented 5 years ago

No worries man, I'd fix it but don't have much time right now because I had a pop-up blocker on so the popup returned an unexpected value from the alert box.

-Jim

On Sat, 15 Dec 2018, 14:00 jamesej <notifications@github.com wrote:

Hi thanks for taking the time to report this issue. Can you explain further what validation you would be expecting? We already have confirmation by the user and role checking within the API it calls.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jamesej/lyniconanc/issues/10#issuecomment-447570711, or mute the thread https://github.com/notifications/unsubscribe-auth/AL16FEEFEq2mbu4C4UWMO83SwMJQTEBTks5u5QCGgaJpZM4ZMUQn .

jamesej commented 5 years ago

OK thanks, I'll make the check explicit, but one day it would be nice to use a JS modal - at some point we need to refresh the UI so might do it then.