search

jamesflorentino / nanoScrollerJS

A jQuery plugin that offers a simplistic way of implementing Lion OS scrollbars.
http://jamesflorentino.github.com/nanoScrollerJS/
MIT License
2.69k stars 502 forks source link

fix the slider positioning on dragging #246

Closed vasilica-olariu closed 10 years ago

vasilica-olariu commented 10 years ago

The slider had a problem when starting the dragging outside the "slider thumb".

vasilica-olariu commented 10 years ago

Meanwhile, fixed the slider's positioning when using the scrolling wheel too. To replicate: scroll the content (using the scrolling wheel); the content will scroll, but the scrollbar won't update. The fix: if we already have an request for animation frame, we'll cancel it and request another one with the updated data.

Related gif: https://dl.dropboxusercontent.com/u/128174652/Licecap/wheel.gif (look at the content's scrolling and scrollbar positioning).

kristerkari commented 10 years ago

Thanks! I'll try to review/test this asap.

kristerkari commented 10 years ago

Sorry that I haven't verified this PR yet. I'll try to find time for it.

kristerkari commented 10 years ago

Looks like this is ok merge. I found that the slider is not really working in Mac Safari, but that is not related to this PR.

Thanks for contributing!