search

jamesflorentino / nanoScrollerJS

A jQuery plugin that offers a simplistic way of implementing Lion OS scrollbars.
http://jamesflorentino.github.com/nanoScrollerJS/
MIT License
2.69k stars 502 forks source link

AMD version #266

Closed SimenB closed 10 years ago

SimenB commented 10 years ago

Hi!

I really like this plugin, makes things a lot prettier than the fugly default bar. Thank you!

I was wondering if you'd be willing to add an AMD-wrapper to the plugin?

As a by-question, in IE8, when I have a selection and manually drag the scroll... thingy, I lose my selection. Using the scrollwheel works fine. Am I doing something wrong, or won't it work at all?

kristerkari commented 10 years ago

Yeah for sure we can add a AMD wrapper is there is use for it. Do you want to contribute the wrapper with a pull request?

Your IE8 problem, could it be realted to this bug #244?

SimenB commented 10 years ago

Sure I can provide a PR. I'm not able to run the tests, though. Running grunt test fails 31 of 34, and deletes a _SpecRunner.html file. Running the SpecRunner.html in test directory in Chrome fails 3 tests. Any idea?

Regarding the bug, I'm not sure, I'd have to test at work on Monday

kristerkari commented 10 years ago

The CLI test runner is broken at the moment, I need to have a look at that at some point. I need to have a look at the failing tests.

I'm planning to rewrite nanoScroller when I have enough time and motivation, and then I can also do improvements for testing the library.