jamesflorentino / nanoScrollerJS

A jQuery plugin that offers a simplistic way of implementing Lion OS scrollbars.

http://jamesflorentino.github.com/nanoScrollerJS/

MIT License

2.69k stars 502 forks source link

Publish to npm #291

Closed SimenB closed 9 years ago

SimenB commented 9 years ago

Please? :smile:

It's the official way to distribute jQuery plugins. https://plugins.jquery.com/

kristerkari commented 9 years ago

Sure thing.

kristerkari commented 9 years ago

npm publish is returning status 500 for me at the moment, so no npm release yet :) I'll try again later so let's keep this open.

SimenB commented 9 years ago

You have to create a user, probably. https://docs.npmjs.com/getting-started/publishing-npm-packages

kristerkari commented 9 years ago

I have a user created:

↳ npm whoami
kristerkari

Probably something else wrong...

SimenB commented 9 years ago

Ah, ok. Nothing reported at their status, though. http://status.npmjs.org/

EDIT: @kristerkari just tried to publish to test, and it works fine now. Removed myself as owner, and added you.

npm owner ls nanoscroller
kristerkari <krister.kari@webtehdas.fi>

I stand as publisher and collaborator, but the project only appears under your username, so it'll probably straighten itself when you next publish :smile:

kristerkari commented 9 years ago

@SimenB Thanks!

calebboyd commented 9 years ago

It looks like the main field is incorrect (or incorrect files are published) in the npm package.

SimenB commented 9 years ago

Yeah, main is missing bin/ prefix. Sorry about that... :S But the bin directory is included, right? You just have to require manually inside the package?

On Wed, 29 Apr 2015 21:46 Caleb Boyd notifications@github.com wrote:

It looks like the main field is incorrect (or incorrect files are published) in the npm package.

— Reply to this email directly or view it on GitHub https://github.com/jamesflorentino/nanoScrollerJS/issues/291#issuecomment-97558033 .

calebboyd commented 9 years ago

Yeah you can still use it but is broken for other managers (jspm)

SimenB commented 9 years ago

283 seems to be where it came from. I probably should have noticed it in #292, though...

I changed format to amd from global. This package has a UMD wrapper, and from what I remember from googling, amd is what should be put there

kristerkari commented 9 years ago

Doh, I'll have to push a new version then.

SimenB commented 9 years ago

@kristerkari Throwing together a PR now, gimme 5 min. Why #283 did not include bin/ I'm unsure of though. @scoarescoare?

calebboyd commented 9 years ago

On another note, it works great as a github install on jspm

SimenB commented 9 years ago

@calebboyd, ok, so the stuff from #283 is correct, it's only the main-field messing up when it's from npm?

calebboyd commented 9 years ago

Yeah, github/jspm install works fine. its just for npm that it appears to be broken.

scott-coates commented 9 years ago

@SimenB bin/ is included, in a way, because it's defined as the directories.lib config parameter.

SimenB commented 9 years ago

Ok, cool. The more you know :smile:

kristerkari commented 9 years ago

Thanks for the fixes guys.

Does npm see the changes now, or is there a need to to publish a new version?

SimenB commented 9 years ago

You'll need to publish

On Thu, 30 Apr 2015 08:25 Krister Kari notifications@github.com wrote:

Thanks for the fixes guys.

Does npm see the changes now, or is there a need to to publish a new version?

— Reply to this email directly or view it on GitHub https://github.com/jamesflorentino/nanoScrollerJS/issues/291#issuecomment-97676691 .

kristerkari commented 9 years ago

version 0.8.7 is out

domialex commented 9 years ago

Is it possible to change the bin directory to dist or something similar? Since bin is blocked by IIS and some other webservers. (by default)