jamesgeer / conf-twitter-bot

A Twitter Bot to post about academic papers
MIT License
4 stars 0 forks source link

Kar paper scraping #110

Closed EdwardChristian closed 1 year ago

EdwardChristian commented 1 year ago
EdwardChristian commented 1 year ago

I don't like these custom db queries in the tests, please write a method in the papers model with its own test and then use that method to test your scraper in the future please, otherwise lgtm.

My view is that testing should be independent from other modules, to avoid circular dependency cycles and weird conversations later on (e.g. why does this change in papers-model break the scraper tests?). It would induce a bit of test-code coupling, which for the scraper tests, which are already limited, i think is avoidable and looks readable.

This is also the final "paper source" so there should be no more need for any extra paper findFirst parts