QH-43 ELO Graph - Githubissues

jamesgiu / quick-hit

Table tennis ELO application using React and Firebase

https://jamesgiu.github.io/quick-hit/

MIT License

12 stars 0 forks source link

Closed Huskehhh closed 3 years ago

Huskehhh commented 3 years ago

IM SORRY LUKE IT WAS FAR TOO TEMPTING

ChrisNeedham24 commented 3 years ago

Might be able to take a look at this at some point, but probably not that soon. Congrats on your first PR though @Huskehhh

jamesgiu commented 3 years ago

Looking pretty cool! One thing though, it's not super responsive on smaller res, might require some relational CSS and no fixed widths/heights

ChrisNeedham24 commented 3 years ago

I've got a spare couple of hours, I'll take a look now.

ChrisNeedham24 commented 3 years ago

I think I'd probably still want the ability to show/hide the graph as well.

Huskehhh commented 3 years ago

Looking sick overall, I just think it'd be good to have the ability to show/hide the graph as well. Not a deal breaker, though.

You're a legend! Thanks for going through and fixing that stuff up 👍

jamesgiu commented 3 years ago

Bloody nice work @Huskehhh and thanks for addressing the comments @ChrisNeedham24