search

jameshadfield / phandango

an interactive viewer for populations of bacterial genomes linked by a phylogeny
http://phandango.net
MIT License
113 stars 27 forks source link

ensure blocks are displayed correctly #3

Open jameshadfield opened 9 years ago

jameshadfield commented 9 years ago

I'm pretty sure the blocks are not being displayed correctly, and it changes while interacting with the canvases.

What's the best way to identify the problem? Design a custom set of blocks and check them visually?

jameshadfield commented 9 years ago

You can see this clearly after commit 2ee049de718fb3ba7faed72b8ab9fb6dc40b4ed1

The background shading uses the same method as the red gubbins blocks do for finding the max and min y values for a set of taxa. E.g. clicking on node 7 on the tree shows this:

image

This is the same underlying bug causing the red blocks to extend too far.

\ there may be more issues with block display other than this **

jameshadfield commented 8 years ago

This has been fixed (quite some time ago) so I don't think it's a bug.

That being said, it would be nice to check the output against a known pdf to verify at some point.