Malformed JSON in response of "stats" call

[CryptoThargor]

I have a Bitmain Antminer S9 with BMminer Version 2.0.0. I use the api-example.py script from the git repo and send

s.send(json.dumps({"command":"stats"}))

The script then fails with an error for "response = json.loads(response)" because the string, which the bmminer api returns is malformed.

{ "STATUS": [{ "STATUS": "S", "When": 1542106834, "Code": 70, "Msg": "BMMiner stats", "Description": "bmminer 1.0.0" }], "STATS": [{ "BMMiner": "2.0.0", "Miner": "16.8.1.3", "CompileTime": "Wed May 3 18:38:52 CST 2017", "Type": "Antminer S9" } { "STATS": 0, "ID": "BC50", "Elapsed": 1911, "Calls": 0, "Wait": 0.000000, "Max": 0.000000, "Min": 99999999.000000, "GHS 5s": "13817.30", "GHS av": 13772.10, "miner_count": 3, "frequency": "650", "fan_num": 2, "fan1": 0, "fan2": 0, "fan3": 2400, "fan4": 0, "fan5": 0, "fan6": 3720, "fan7": 0, "fan8": 0, "temp_num": 3, "temp1": 0, "temp2": 0, "temp3": 0, "temp4": 0, "temp5": 0, "temp6": 71, "temp7": 71, "temp8": 72, "temp9": 0, "temp10": 0, "temp11": 0, "temp12": 0, "temp13": 0, "temp14": 0, "temp15": 0, "temp16": 0, "temp2_1": 0, "temp2_2": 0, "temp2_3": 0, "temp2_4": 0, "temp2_5": 0, "temp2_6": 79, "temp2_7": 80, "temp2_8": 82, "temp2_9": 0, "temp2_10": 0, "temp2_11": 0, "temp2_12": 0, "temp2_13": 0, "temp2_14": 0, "temp2_15": 0, "temp2_16": 0, "temp3_1": 0, "temp3_2": 0, "temp3_3": 0, "temp3_4": 0, "temp3_5": 0, "temp3_6": 0, "temp3_7": 0, "temp3_8": 0, "temp3_9": 0, "temp3_10": 0, "temp3_11": 0, "temp3_12": 0, "temp3_13": 0, "temp3_14": 0, "temp3_15": 0, "temp3_16": 0, "freq_avg1": 0.00, "freq_avg2": 0.00, "freq_avg3": 0.00, "freq_avg4": 0.00, "freq_avg5": 0.00, "freq_avg6": 650.00, "freq_avg7": 650.00, "freq_avg8": 650.00, "freq_avg9": 0.00, "freq_avg10": 0.00, "freq_avg11": 0.00, "freq_avg12": 0.00, "freq_avg13": 0.00, "freq_avg14": 0.00, "freq_avg15": 0.00, "freq_avg16": 0.00, "total_rateideal": 14004.90, "total_freqavg": 650.00, "total_acn": 189, "total_rate": 13817.30, "chain_rateideal1": 0.00, "chain_rateideal2": 0.00, "chain_rateideal3": 0.00, "chain_rateideal4": 0.00, "chain_rateideal5": 0.00, "chain_rateideal6": 4668.30, "chain_rateideal7": 4668.30, "chain_rateideal8": 4668.30, "chain_rateideal9": 0.00, "chain_rateideal10": 0.00, "chain_rateideal11": 0.00, "chain_rateideal12": 0.00, "chain_rateideal13": 0.00, "chain_rateideal14": 0.00, "chain_rateideal15": 0.00, "chain_rateideal16": 0.00, "temp_max": 82, "Device Hardware%": 0.0000, "no_matching_work": 0, "chain_acn1": 0, "chain_acn2": 0, "chain_acn3": 0, "chain_acn4": 0, "chain_acn5": 0, "chain_acn6": 63, "chain_acn7": 63, "chain_acn8": 63, "chain_acn9": 0, "chain_acn10": 0, "chain_acn11": 0, "chain_acn12": 0, "chain_acn13": 0, "chain_acn14": 0, "chain_acn15": 0, "chain_acn16": 0, "chain_acs1": "", "chain_acs2": "", "chain_acs3": "", "chain_acs4": "", "chain_acs5": "", "chain_acs6": " oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo ooooooo", "chain_acs7": " oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo ooooooo", "chain_acs8": " oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo oooooooo ooooooo", "chain_acs9": "", "chain_acs10": "", "chain_acs11": "", "chain_acs12": "", "chain_acs13": "", "chain_acs14": "", "chain_acs15": "", "chain_acs16": "", "chain_hw1": 0, "chain_hw2": 0, "chain_hw3": 0, "chain_hw4": 0, "chain_hw5": 0, "chain_hw6": 0, "chain_hw7": 0, "chain_hw8": 0, "chain_hw9": 0, "chain_hw10": 0, "chain_hw11": 0, "chain_hw12": 0, "chain_hw13": 0, "chain_hw14": 0, "chain_hw15": 0, "chain_hw16": 0, "chain_rate1": "", "chain_rate2": "", "chain_rate3": "", "chain_rate4": "", "chain_rate5": "", "chain_rate6": "4662.91", "chain_rate7": "4478.88", "chain_rate8": "4675.51", "chain_rate9": "", "chain_rate10": "", "chain_rate11": "", "chain_rate12": "", "chain_rate13": "", "chain_rate14": "", "chain_rate15": "", "chain_rate16": "", "chain_xtime6": "{}", "chain_xtime7": "{X47=3,X49=18}", "chain_xtime8": "{}", "chain_offside_6": "0", "chain_offside_7": "0", "chain_offside_8": "0", "chain_opencore_6": "0", "chain_opencore_7": "0", "chain_opencore_8": "0", "miner_version": "16.8.1.3" }], "id": 1 }

There is a missing "," between "} {" after "Type": "Antminer S9"

I tested that with other programming languages. Thats not a problem only with python.

[jameshilliard]

Use https://github.com/ckolivas/cgminer instead, it's fixed there.

[CryptoThargor]

We maintain thousands of miner, so we cannot switch manually to cgminer on all of them. And is there a guaranty, that future firmwares will cause no troubles with cgminer? The webinterface is based on the bmminer-api.

[jameshilliard]

Well obviously you would automate the update and would probably want to build it into custom firmware(I've tested cgminer using my custom firmware build based on buildroot).