Using html-webpack-plugin >=2.24.1 shows warnings

jamesjieye / html-webpack-exclude-assets-plugin

Add the ability to exclude assets based on RegExp patterns

MIT License

52 stars 14 forks source link

Using html-webpack-plugin >=2.24.1 shows warnings #6

Closed js3692 closed 7 years ago

js3692 commented 7 years ago

After https://github.com/jantimon/html-webpack-plugin/commit/4e29b022b89a6eeb7ba93ba92d0e955e83d2b997 and https://github.com/jantimon/html-webpack-plugin/commit/bac1cd4469ccc695464f1f98bf2accb3b48734fa were introduced, the plugin started to give errors for callbacks used without results.

Example:

This is not an important issue, but the warnings started to clutter my output with multiple instances of HtmlWebpackPlugin. @jamesjieye Could you please look at the opened PR?

jamesjieye commented 7 years ago

@js3692 sorry for the late response and thank your for the pull request. I have merged your pull request. And the cause of the Travis build failure is the upgrade of loader-utils, which used by style-loader, to 1.0.2. And loader-utils only supports node >=4.0.0 and therefore the build failed in node 0.12 environment.

js3692 commented 7 years ago

Not a problem - thank you for the note!