jamesjonesmath / canvancement

Enhancements to the Canvas LMS
ISC License
215 stars 95 forks source link

rubrics script stopped working #12

Closed teatown closed 5 years ago

teatown commented 5 years ago

I'm using the Rubrics script with Firefox and Tampermonkey since 10/2017 without any issue. Stopped working in the last week. Noticed a red "notification" symbol on Tampermonkey but never actually found the notification. Removed the script and reinstalled but no luck. I do see all the features (points box below the answer for example as you would expect with the script) but the box is non-functional. If I put anything in the lower box and advance to next student the grade is not entered. I've checked for an update but it says it is up-to-date. My domain is: https://olympic.instructure.com. Thanks for any help you can offer. I am lost without the script.

jamesjonesmath commented 5 years ago

When you say "rubric script", it sounds like you're actually talking about QuizWiz. If so, the duplicate header at the bottom is a known issue and I have a bug fix for that particular issue. The person who reported it also reported some other issues as well and I haven't had a chance to track those down. I didn't want to update and then come back in another day or two and update again, but given that classes start in 30 hours and I'm not ready yet, perhaps I should just publish it and see what else doesn't work.

Canvas went through and introduced some hidden fields to hold the actual value but left the other box there to input the value. The kept the identifier with the hidden one and the new one doesn't have an identifier. Hidden boxes don't trigger events when they change.

Was there anything besides the lower box not working? Other than entering a fudge point of 0 not working? That's a Canvas issue, btw, and they have updated their source code to fix it, but I don't know when it's going to become available.

The red notification on Tampermonkey isn't a notification that I know of, it's the number of scripts that are running on that page.

teatown commented 5 years ago

James,

I could hug you right now. We started 2 weeks ago so I am in the thick of grading and panicking like hell that my QuizWiz script (rubrics) was not working. Yes, bottom/lower box was the problem and appears that you’ve fixed it. I rely on that so much. I don’t use fudge points so I had not noticed that.

The other thing I’ve noticed, and this may be a Canvas issue rather than QuizWiz. Previously, at the top of the page where it lists the number of questions on the test/exam horizontally across the page in a numbered box for each question, it would shade out the questions that need grading and you could click on the shaded question number box to go straight to the question(s) that needed grading. That is no longer the case. The list is there but there is no indication of which questions need grading. You now have to scroll up to the top of the page and click on a hyperlink of the questions that need grading. See screenshot attached. Is that anything you have control of?

Once again I am so very grateful for all the help you offer to us coding Luddites out here that are just trying to be more efficient with our time. It is SO appreciated. It has fundamentally improved my quality of life in the amount of time it saves me. So, thank you. If there is ever anything I can do to help you out (formal letter of appreciation/gratitude for your time/work?) let me know.

Mirelle

Mirelle Cohen Ph.D. I-BEST Coordinator Coordinator of the Human Service & Chemical Dependency Professional Programs, Professor of Sociology HSS344 Olympic College 1600 Chester Avenue Bremerton, WA, 98337-1699 Tel: 360 475 7553 Fax: 253 503 3298 Email: mcohen@olympic.edu

From: James Jones notifications@github.com<mailto:notifications@github.com> Reply-To: jamesjonesmath/canvancement reply@reply.github.com<mailto:reply@reply.github.com> Date: Sunday, January 13, 2019 at 12:58 AM To: jamesjonesmath/canvancement canvancement@noreply.github.com<mailto:canvancement@noreply.github.com> Cc: Mirelle Cohen mcohen@olympic.edu<mailto:mcohen@olympic.edu>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: [External] RE: [jamesjonesmath/canvancement] rubrics script stopped working (#12)

When you say "rubric script", it sounds like you're actually talking about QuizWiz. If so, the duplicate header at the bottom is a known issue and I have a bug fix for that particular issue. The person who reported it also reported some other issues as well and I haven't had a chance to track those down. I didn't want to update and then come back in another day or two and update again, but given that classes start in 30 hours and I'm not ready yet, perhaps I should just publish it and see what else doesn't work.

Canvas went through and introduced some hidden fields to hold the actual value but left the other box there to input the value. The kept the identifier with the hidden one and the new one doesn't have an identifier. Hidden boxes don't trigger events when they change.

Was there anything besides the lower box not working? Other than entering a fudge point of 0 not working? That's a Canvas issue, btw, and they have updated their source code to fix it, but I don't know when it's going to become available.

The red notification on Tampermonkey isn't a notification that I know of, it's the number of scripts that are running on that page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jamesjonesmath/canvancement/issues/12#issuecomment-453813005, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsePMZuSdvMYGmdnvb1ovFFjr3ElSfS1ks5vCvU_gaJpZM4Z8z2b.

jamesjonesmath commented 5 years ago

The grade by question's not being highlighted was one of the other things that the other person mentioned as not working anymore. It's probably related to the changes they made on January 5, but I haven't had a chance to look into it yet.

jamesjonesmath commented 5 years ago

I fixed the highlighting of answers when grading a question at a time. Canvas changed the name of the class from "short_answer_question" to "essay_question" and I wasn't looking for that. I added "essay_question" to the list of classes to look for and it worked.

I could have left it like that, but I decided to go ahead and do some more while I had it. I now look at the score for the equation and if it is already graded, then it sets the opacity to 50% so it's easy to tell which questions are completely missing a grade.

You may need to go into the Tampermonkey dashboard and update the script (by clicking on the value in the Last Updated column for that Canvancement). It's sufficiently different that it may ask you to verify the changes rather than making them automatically.

teatown commented 5 years ago

James,

Ungraded answers are still not highlighted for me. I did as you said and clicked on the last updated column and it said 22 hours ago and wouldn't let me do anything else. So, I uninstalled and reinstalled the rubrics script but no change.

just FYI.

Mirelle

Mirelle Cohen Ph.D. I-BEST Coordinator Coordinator of the Human Service & Chemical Dependency Professional Programs, Professor of Sociology HSS344 Olympic College 1600 Chester Avenue Bremerton, WA, 98337-1699 Tel: 360 475 7553 Fax: 253 503 3298 Email: mcohen@olympic.edu


From: James Jones [notifications@github.com] Sent: Sunday, January 13, 2019 3:42 PM To: jamesjonesmath/canvancement Cc: Cohen, Mirelle; Author Subject: [External] RE: [jamesjonesmath/canvancement] rubrics script stopped working (#12)

I fixed the highlighting of answers when grading a question at a time. Canvas changed the name of the class from "short_answer_question" to "essay_question" and I wasn't looking for that. I added "essay_question" to the list of classes to look for and it worked.

I could have left it like that, but I decided to go ahead and do some more while I had it. I now look at the score for the equation and if it is already graded, then it sets the opacity to 50% so it's easy to tell which questions are completely missing a grade.

You may need to go into the Tampermonkey dashboard and update the script (by clicking on the value in the Last Updated column for that Canvancement). It's sufficiently different that it may ask you to verify the changes rather than making them automatically.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jamesjonesmath/canvancement/issues/12#issuecomment-453876739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsePMbdnrda0ELMKqXZxds56CE-s6L2pks5vC8RqgaJpZM4Z8z2b.

teatown commented 5 years ago

I think you updated the quizzes script but not the rubrics script because rubrics says updated 9 months ago on this page but quizzes says 4 hours ago?

https://github.com/jamesjonesmath/canvancement

Mirelle Cohen Ph.D. I-BEST Coordinator Coordinator of the Human Service & Chemical Dependency Professional Programs, Professor of Sociology HSS344 Olympic College 1600 Chester Avenue Bremerton, WA, 98337-1699 Tel: 360 475 7553 Fax: 253 503 3298 Email: mcohen@olympic.edu


From: James Jones [notifications@github.com] Sent: Sunday, January 13, 2019 3:42 PM To: jamesjonesmath/canvancement Cc: Cohen, Mirelle; Author Subject: [External] RE: [jamesjonesmath/canvancement] rubrics script stopped working (#12)

I fixed the highlighting of answers when grading a question at a time. Canvas changed the name of the class from "short_answer_question" to "essay_question" and I wasn't looking for that. I added "essay_question" to the list of classes to look for and it worked.

I could have left it like that, but I decided to go ahead and do some more while I had it. I now look at the score for the equation and if it is already graded, then it sets the opacity to 50% so it's easy to tell which questions are completely missing a grade.

You may need to go into the Tampermonkey dashboard and update the script (by clicking on the value in the Last Updated column for that Canvancement). It's sufficiently different that it may ask you to verify the changes rather than making them automatically.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jamesjonesmath/canvancement/issues/12#issuecomment-453876739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsePMbdnrda0ELMKqXZxds56CE-s6L2pks5vC8RqgaJpZM4Z8z2b.

teatown commented 5 years ago

Just uninstalled "rubrics" and installed "speed enhancements" and still no luck on highlighting ungraded questions. FYI. I'll leave you alone now.

Mirelle Cohen Ph.D. I-BEST Coordinator Coordinator of the Human Service & Chemical Dependency Professional Programs, Professor of Sociology HSS344 Olympic College 1600 Chester Avenue Bremerton, WA, 98337-1699 Tel: 360 475 7553 Fax: 253 503 3298 Email: mcohen@olympic.edu


From: James Jones [notifications@github.com] Sent: Sunday, January 13, 2019 3:42 PM To: jamesjonesmath/canvancement Cc: Cohen, Mirelle; Author Subject: [External] RE: [jamesjonesmath/canvancement] rubrics script stopped working (#12)

I fixed the highlighting of answers when grading a question at a time. Canvas changed the name of the class from "short_answer_question" to "essay_question" and I wasn't looking for that. I added "essay_question" to the list of classes to look for and it worked.

I could have left it like that, but I decided to go ahead and do some more while I had it. I now look at the score for the equation and if it is already graded, then it sets the opacity to 50% so it's easy to tell which questions are completely missing a grade.

You may need to go into the Tampermonkey dashboard and update the script (by clicking on the value in the Last Updated column for that Canvancement). It's sufficiently different that it may ask you to verify the changes rather than making them automatically.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jamesjonesmath/canvancement/issues/12#issuecomment-453876739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsePMbdnrda0ELMKqXZxds56CE-s6L2pks5vC8RqgaJpZM4Z8z2b.