fix processFunctionDeclarator does not check function const-qualifier…

[iteemhe]

… and if it is a member function

296

[iteemhe]

False positive has been fixed. Convert to a pull request

[jamesjuett]

Your fix is I think the best way to handle this given that the Declarator itself doesn't carry any information about the presence of that const other than in the recieverType, which will be undefined if it's not a member function.

But, I think the best approach would be to fix the underlying issues/bugs (which are obviously not your fault!):

• A declarator for a qualified name that might be an out-of-line function definition won't have the appropriate class context, so decisions about whether or not const is allowed can't be made here.
• Similarly, determining the function receiver type can't be done in a declarator. Likely if a Declarator is created in a context that could be an out-of-line function definition, the function type needs to be fixed up afterward, perhaps when it is checked against other linked entities.

In FunctionDefinition.ts there's some relevant code:

Here, in the case of an out-of-line definition, the declarator that's created actually comes out with a type is a function type with an undefined receiverType. We'd need to either fix this somehow by comparing to the linked entity it's matched against, or I suppose ensure the proper class context was originally provided to the declarator somehow. Perhaps the Declarator class could actually preprocess the qualified name to determine that?

I'm not sure - this issue goes a bit deeper. Lobster unfortunately wasn't built with qualified names in mind and the support is a little bit shaky.

I'll need to think about this a bit more...