search

jameskleeh / angular-confirm

Confirmation modal dialog for AngularJS
Apache License 2.0
150 stars 75 forks source link

$modal is now deprecated. Use $uibModal instead. #24

Closed dimitriscsd closed 8 years ago

dimitriscsd commented 9 years ago

Hello.

Angular UI (version: 0.14.3) have changed the naming convention of their services. They prefix them with 'uib' now.

Could you please make this change on your library as well so we stop getting the deprecation warning whenever we use it?

Thanks in advance.

jameskleeh commented 9 years ago

I'll have to start a new branch for this as it is a breaking change

dimitriscsd commented 8 years ago

So is this planned to happen? From my research it looks like it's a simple rename in this case. Separate branch sounds good, I suppose. However maybe the old functionality should be on another branch and the up-to-date stuff on master? Just a suggestion :)

alexweber commented 8 years ago

:+1:

jameskleeh commented 8 years ago

1.2.0 is released. Thank you for the suggestion!

sargue commented 8 years ago

You forgot to rebuild the minified file, drove me mad to find it...;-)

dimitriscsd commented 8 years ago

I can confirm that the minified version of the file is still using the old stuff.

Thanks for the heads up sargue.

jameskleeh commented 8 years ago

Ugh I apologize. It seems like I can never get this right 100%.