jameskleeh / angular-confirm

Confirmation modal dialog for AngularJS
Apache License 2.0
150 stars 75 forks source link

Fix needed for dependency injection #26

Closed jquinter closed 8 years ago

jquinter commented 8 years ago

As recommended in this famous guide, dependency injection should be explicit, not using shortcut syntax

https://github.com/johnpapa/angular-styleguide#manual-annotating-for-dependency-injection

This happened with the master version of angular-confirm: using a processor (grunt concat) and minification (grunt uglify), the angular-confirm.js file transformation resulted in many errors.

This pull request fixes this issue.

jameskleeh commented 8 years ago

@jquinter I included a minified version for this reason. I personally use a pre processor to do this work for me