search

jameskleeh / angular-confirm

Confirmation modal dialog for AngularJS
Apache License 2.0
150 stars 75 forks source link

Update angular-confirm.js to support custom response messages #32

Closed jcford73 closed 8 years ago

jcford73 commented 8 years ago

Supporting customized response messages allows custom templates to offer more than the standard 'ok' and 'cancel' buttons.

jcford73 commented 8 years ago

Done

jameskleeh commented 8 years ago

I'm still seeing if (typeof dismissMessage === 'undefined'). Forget to push?

jcford73 commented 8 years ago

Do I need to do something to the pull request to make it update?

jameskleeh commented 8 years ago

You just need to push to your repository

On Mon, Jan 18, 2016 at 9:33 AM, JC Ford notifications@github.com wrote:

Do I need to do something to the pull request to make it update?

— Reply to this email directly or view it on GitHub https://github.com/Schlogen/angular-confirm/pull/32#issuecomment-172541827 .

jcford73 commented 8 years ago

I did. It's showing in the master for my fork.

jcford73 commented 8 years ago

And that was the problem. I forgot I had done the pull request against a branch. Sorry for the confusion.

jcford73 commented 8 years ago

Was there anything else you wanted me to do before you merge?