jameskleeh / angular-confirm

Confirmation modal dialog for AngularJS
Apache License 2.0
150 stars 75 forks source link

Changed buildstep so the main bower file gets ng-annotated also #62

Closed mbrand closed 8 years ago

mbrand commented 8 years ago

Hi!

We were having problems with your bower config because your main file declared in the bower.json didn't have annotations. Alot of build tools depend on these main file declarations and minify those. I changed your buildstep to put the build into a dist/ folder and adjusted the bower.json accordingly. Would love to see a new version of this :).

jameskleeh commented 8 years ago

@mbrand Do you use ngAnnotate as part of your build process?

mbrand commented 8 years ago

@Schlogen Yes I do. But I really only do it for my own files and not for libs, as I think that libs should run "out of the box".

jameskleeh commented 8 years ago

@mbrand Thanks for the reply. The minified version will run "out of the box". What prevents you from using that?

mishupetre commented 8 years ago

First of all, thanks for maintaining this package, @Schlogen. Encountered the same problem here. I like to use full lib version when developing and minify it in the build process when deploying to a server, so I'd like to see @mbrand's suggestion implemented as well.

mbrand commented 8 years ago

@Schlogen Build tools like https://github.com/jonkemp/gulp-useref are relying on the lib file specified as main. You can overwrite this behavior of course, but in my opinion the file that's specified as main should simply run out of the box, even if it's used in a minified build. I think a consumer of a Libraray shouldn't need any additional steps to make it run either minified or not.

katagaStyle commented 8 years ago

Same issue here. @mbrand++

jameskleeh commented 8 years ago

I'm closing this PR as it is a breaking change to move where the files are located. Instead due to the amount of requests I've received about it, even though I disagree, I've annotated the non minified file version 1.2.5.