Sources don't build - Githubissues

kortov commented 5 years ago

I think the reason is because the old codenarc pulls the new groovy, I think upgrading codenarc could solve the problem despite the need to update the rules Снимок24

Here's the link

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':codenarcMain'.
> java.lang.NoClassDefFoundError: groovy/text/SimpleTemplateEngine

jameskleeh commented 5 years ago

I've updated codenarc and now it fails for a different reason

kortov commented 5 years ago

There are many ways to fix that, I'll push a PR with fixes, may be you'll add some more there, but here are the details:

Codenarc enhanced rules require all the dependencies (for example POI) in the classpath link. Honestly I don't know the way how to give him the classpath so I removed those rules. As I can see, your last successful build logged such errors

Compilation failed for [CustomCompilerPhaseSourceDecorator[SourceFile[/home/travis/build/jameskleeh/groovy-excel-builder/src/main/groovy/com/jameskleeh/excel/Column.groovy]]].

but it worked in codenarc 0.25.2. You can simply return codenarc to this version with this (I'm not good at gradle, for me it the easiest way to force dependency)

configurations.all {
    resolutionStrategy.eachDependency { DependencyResolveDetails details ->
        if (details.requested.group == 'org.codehaus.groovy') {
            details.useVersion '2.4.7'
        }
    }
}

and build will succed.

But I just removed some unnecessary rules, fixed some errors and added java plugin for easier ide support of the project, please check the PR

These were codenarc intermediate results codenarc-results.zip

jameskleeh / groovy-excel-builder

Sources don't build #26