search

jamesknelson / create-react-blog

Start and deploy your own statically rendered blog with create-react-app
https://create-react-blog.netlify.com/
MIT License
550 stars 69 forks source link

Linter warnings alt required for <Img tags #7

Open NickFoden opened 5 years ago

NickFoden commented 5 years ago

Maybe this is a within markdown issue so a non issue?

But I believe the default create react app linting that warns <img tags require an alt attribute is turned off and I suggest this project turns that warning back on.

jamesknelson commented 5 years ago

AFAIK the linter can't lint markdown files, so this would be pretty hard to fix

I'll close this for now, but feel free to re-open if you want to try submitting a PR with a fix to react-scripts-mdx.

NickFoden commented 5 years ago

Realized this is also issue in regular .js components. Is this easy linting rule to put back? I think where possible good to remind users to include this alt tag for <img in their .js components.

I will look for linting markdown, but I think you are right may be hard/impossible to do.

jamesknelson commented 5 years ago

This should definitely work for .js files. Not sure what's gone wrong.