search

jamesknelson / gulp-rev-replace

Rewrite occurences of filenames which have been renamed by gulp-rev
MIT License
388 stars 62 forks source link

Add options to modify the name of the unreved/reved files before using them #32

Closed mrkipling closed 9 years ago

mrkipling commented 9 years ago

This PR adds two new options: modifyReved and modifyUnreved.

I have updated the README to explain in more detail what is happening here. There are only a few new lines of code so hopefully they should be fairly self-explanatory.

mrkipling commented 9 years ago

Hi - any word on this?

I needed to add this feature in order to get sourcemaps+cachebusting working for our build. Am currently using our fork but it would obviously be good if it were merged.

jamesknelson commented 9 years ago

I like this implementation, it seems flexible and is pretty easy to understand. If you can add tests, I'd be happy to merge it.

mrkipling commented 9 years ago

Sorry for the delay - have just pushed some tests that check modifyReved and modifyUnreved work as expected.

jamesknelson commented 9 years ago

Thanks, merged!

mrkipling commented 9 years ago

Thanks!

mrkipling commented 9 years ago

Would it be possible to update this on npm? Or is that an automatic process? (I don't have much experience publishing to npm myself)

jamesknelson commented 9 years ago

It totally slipped my mind, thanks for reminding me. I've just published 0.4.2.

mrkipling commented 9 years ago

Excellent, thank you.