search

jamesknelson / gulp-rev-replace

Rewrite occurences of filenames which have been renamed by gulp-rev
MIT License
389 stars 62 forks source link

Fix issue of not replacing non-canonical URIs (Issue #1) with tests #5

Closed jlas closed 10 years ago

jlas commented 10 years ago

This is the same issue as mentioned in Issue #1

I have extended the original test to confirm that it does not pass on Windows.

I implemented a configurable solution, which defaults to On, which replaces filepath separator to the canonical URI separator: the forward slash (/) (http://tools.ietf.org/html/rfc3986).

The reason to have it configurable is so if any users rely on the old behavior they can easily revert to that.

I also added a second test to ensure the option works in the non-default state as well.

kasperisager commented 10 years ago

Works a treat on my end!

jamesknelson commented 10 years ago

Thanks! Sorry about the delay merging it.