search

jamesladd / stc

stc
Other
3 stars 2 forks source link

Simple fix for the path name to package conversion for windows #25

Closed mattys101 closed 6 years ago

mattys101 commented 6 years ago

The replaceAll didn't like it when it received the backslash path separator on Windows. Changed it to simply replace using characters.

jamesladd commented 6 years ago

Seems to think the whole files has changed - are we out of whack w tabs v spaces?

Which lines did you change?

Sent from my Commodore 64

On 24 Oct 2017, at 10:00 pm, Matnotifications@github.com wrote:

The replaceAll didn't like it when it received the backslash path separator on Windows. Changed it to simply replace using characters.

You can view, comment on, or merge this pull request online at:

https://github.com/jamesladd/stc/pull/25

Commit Summary

Fix for path name->package name conversion when on Windows. Merge branch 'fix/srcfile-pkgname' File Changes

M src/main/java/st/redline/classloader/SmalltalkSourceFile.java (434) Patch Links:

https://github.com/jamesladd/stc/pull/25.patch https://github.com/jamesladd/stc/pull/25.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kdriedger commented 6 years ago

Line endings? https://help.github.com/articles/dealing-with-line-endings/

mattys101 commented 6 years ago

Line endings would probably do it. Although wouldn't have thought Eclipse with the Git plugin would cause that kind of issue. :-(

The actual changed line was 175.

I'll check out that link and make sure my configuration doesn't do that again. Sorry.

mattys101 commented 6 years ago

Should I try to fix this at my end and then redo the pull request? If so, what's the best way? I'm not a huge fan of rewriting the commit history and not 100% sure how to do it either

jamesladd commented 6 years ago

Happy if you make a new pull request and delete the old one

Sent from my Commodore 64

On 2 Nov 2017, at 10:27 am, Matt notifications@github.com wrote:

Should I try to fix this at my end and then redo the pull request? If so, what's the best way? I'm not a huge fan of rewriting the commit history and not 100% sure how to do it either

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mattys101 commented 6 years ago

Killing this off as I (think) I have fixed the line endings.

mattys101 commented 6 years ago

Ok, fixed it, but it appears to have attached to the same pull request? (which is a little scary, aren't the commits associated with a unique identifier? Looking at the changes it appears to be correct with only a single line change.)