jameslafferty / Term-Menu-Order

2 stars 9 forks source link

Incompatibilities with Wordpress SEO (by Yoast) [fix included] #2

Open arminrosu opened 12 years ago

arminrosu commented 12 years ago

After activating the plugin, 4 fields started appearing in quick edit mode, on custom post types. After debugging, I found they were triggered by the custom columns Wordpress SEO adds.

This can be fixed by modifying "/lib/ns_tmo_plugin.class.php":

public function quick_edit_menu_order ($column_name, $post_type) {
        if ( $column_name === 'menu_order') {
            $menu_order_field = '<fieldset><div class="inline-edit-col"><label><span class="title">' . __( 'Order' , 'term-menu-order') . '</span><span class="input-text-wrap"><input class="ptitle" name="'. self::$form_field_name . '" type="text" value="" /></span></label></div></fieldset>';

            $menu_order_field .= '<script type="text/javascript">

            </script>';

            echo $menu_order_field;
        }

    }

Also, the "quick_edit_custom_box" action sets 2 parameters, not 3, thus:

add_action('quick_edit_custom_box', array(&$this, 'quick_edit_menu_order'), 10, 2);
ryanjbonnell commented 11 years ago

Has there been any activity on getting this bug officially fixed (and a new version of the plugin released)?