jameslamb commented 4 years ago

black recently did a new release. This PR reformats this project's code per that new release.

It also introduces a Makefile so you can just do make format (to format the code) and make lint (to run the linter) without needing to know about the shell scripts.

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0002a5d). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             main      #193   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         6           
  Lines           ?       323           
  Branches        ?         0           
========================================
  Hits            ?       323           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0002a5d...68cee4b. Read the comment docs.

jameslamb commented 4 years ago

dealing with this issue only on the Python 3.8 builds:

###############
#    mypy     #
###############
doppel/describe.py:72: error: "Logger" has no attribute "fatal"
doppel/describe.py:82: error: "Logger" has no attribute "fatal"
doppel/describe.py:104: error: "Logger" has no attribute "fatal"
Found 3 errors in 1 file (checked 13 source files)
The command ".ci/test.sh" exited with 255.

I just put a #type: ignore on those instances. That code is heavily covered by tests so I know nothing bad is happening.

jameslamb / doppel-cli

[ci] updates for new version of black #193

Codecov Report