jamesleesaunders / PyAlertMe

Python Hive Hub
MIT License
15 stars 3 forks source link

Added Additional AM Cluster attributes and updated unit testing #59

Closed jrjefferies closed 6 years ago

jrjefferies commented 6 years ago

Adding more info for AM cluster commands Added new variables to the node class, to hold new data from the status messages Updated node status (both generate and parse) in light of new info on the fields Updates unit testing in light of the new knowledge on the status fields

codecov[bot] commented 6 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.5%. The diff coverage is 94.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
+ Coverage   86.98%   87.48%   +0.5%     
=========================================
  Files          15       15             
  Lines        1137     1199     +62     
=========================================
+ Hits          989     1049     +60     
- Misses        148      150      +2
Impacted Files Coverage Δ
tests/test_zbsensor.py 94.44% <ø> (ø) :arrow_up:
tests/test_zbsmartplug.py 97.91% <ø> (ø) :arrow_up:
tests/test_zbnode.py 99.58% <100%> (ø) :arrow_up:
pyalertme/zbsmartplug.py 66.66% <100%> (+0.95%) :arrow_up:
tests/test_zbhub.py 97.82% <100%> (+0.04%) :arrow_up:
pyalertme/node.py 100% <100%> (ø) :arrow_up:
pyalertme/zbsensor.py 100% <100%> (ø) :arrow_up:
pyalertme/zbhub.py 66.25% <50%> (ø) :arrow_up:
pyalertme/zbnode.py 80.28% <94.2%> (+1.6%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6db1217...46a7515. Read the comment docs.

jamesleesaunders commented 6 years ago

Hi @jrjeffries Happy New Year! I am not ignoring this, just bit busy over festive period.

When I get a moment I will sit down to review properly. Looks great though. Very impressed you managed to work out further manufacturer, version info etc details! How did you work them out?

Will catch up soon!

Thanks so much for this contribution.

J

jrjefferies commented 6 years ago

James, I understand that festive period is busy :). I also sent you a private email

Regards, JJ

On Tue, 2 Jan 2018 at 10:28 James Saunders notifications@github.com wrote:

Hi @jrjeffries Happy New Year! I am not ignoring this, just bit busy over festive period.

When I get a moment I will sit down to review properly. Looks great though. Very impressed you managed to work out further manufacturer, version info etc details! How did you work them out?

Will catch up soon!

Thanks so much for this contribution.

J

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jamesleesaunders/PyAlertMe/pull/59#issuecomment-354737674, or mute the thread https://github.com/notifications/unsubscribe-auth/Aae9L_1x2Qi5lpEz-6lQoyTPcfheaUO6ks5tGgS1gaJpZM4RPpX_ .