Closed jameslittle230 closed 2 years ago
Merging #280 (d42905f) into master (eeaca67) will decrease coverage by
10.67%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #280 +/- ##
===========================================
- Coverage 72.44% 61.77% -10.68%
===========================================
Files 53 15 -38
Lines 2174 518 -1656
Branches 104 104
===========================================
- Hits 1575 320 -1255
+ Misses 598 197 -401
Partials 1 1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c1463e3...d42905f. Read the comment docs.
Benchmark | Baseline | Contender | Comparison |
---|---|---|---|
build/federalist | 229.5537 | 213.1282 | 0.93× 🎉 |
federalist.st | 1125.456 | 271.075 | 0.24× 🎉 |
search/federalist/liberty | 1.9478 | 1.9842 | 1.02× |
stork.js | 21.961 | 21.88 | 1.0× |
stork.wasm | 356.537 | 651.157 | 1.83× ⚠️ |
Baseline: de70fb01688725b7955aa8a48b4fda7ef8be7993; Comparison: d42905f4b278949c40a002508c550e5c7719e2dd
Closing due to staleness
This PR creates a new index serialization format that all new indexes are built with. A new configuration option lets users specify that they want the index data to be compressed (here using bzip2) when written to the output file.
This shrank the Federalist Papers index by a factor of 5x.
Reasons this shouldn't get merged yet: