jameslittle230 / stork

🔎 Impossibly fast web search, made for static sites.
https://stork-search.net
Apache License 2.0
2.73k stars 56 forks source link

Center SVG x in stork-close-button #309

Closed kkwteh closed 2 years ago

kkwteh commented 2 years ago

Add a CSS rule to center the X in the stork-close-button

Before

Capture d’écran 2022-07-30 à 00 49 22

After

Capture d’écran 2022-07-30 à 00 49 11
codecov[bot] commented 2 years ago

Codecov Report

Merging #309 (410427d) into master (eeaca67) will increase coverage by 0.89%. The diff coverage is 81.28%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   72.44%   73.34%   +0.89%     
==========================================
  Files          53       52       -1     
  Lines        2174     2251      +77     
  Branches      104      108       +4     
==========================================
+ Hits         1575     1651      +76     
- Misses        598      599       +1     
  Partials        1        1              
Impacted Files Coverage Δ
stork-cli/src/clap.rs 97.36% <ø> (-2.64%) :arrow_down:
stork-cli/src/io.rs 0.00% <0.00%> (ø)
stork-cli/src/main.rs 0.00% <0.00%> (ø)
stork-lib/src/config/file.rs 96.47% <ø> (ø)
...ries/data_source_readers/url_data_source_reader.rs 0.00% <0.00%> (ø)
stork-lib/src/index_v3/build/fill_stems.rs 100.00% <ø> (ø)
...rk-lib/src/index_v3/search/intermediate_excerpt.rs 0.00% <ø> (ø)
stork-lib/src/input.rs 98.61% <ø> (-1.39%) :arrow_down:
stork-lib/src/lib.rs 36.84% <ø> (+1.75%) :arrow_up:
stork-wasm/src/lib.rs 89.28% <ø> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

kkwteh commented 2 years ago

I can't seem to merge it. I'm seeing this.

Capture d’écran 2022-07-30 à 01 12 09

:

jameslittle230 commented 2 years ago

Sorry about that. I don't get a ton of contributors so I don't get to debug this kind of thing often.

I'll merge it in and take a look at the contribution settings later!

Thanks for contributing :)

-James