jameslittle230 / stork

🔎 Impossibly fast web search, made for static sites.
https://stork-search.net
Apache License 2.0
2.73k stars 56 forks source link

Working with Subtitles | timestamp_format "MinutesAndSeconds" #330

Closed selamhabibi closed 1 year ago

selamhabibi commented 1 year ago

In the Stork-Search documentation you can find an example for searching within a SRT file using the "Vimeo format":

https://stork-search.net/docs/srt

The option "timestamp_format = "MinutesAndSeconds" for rendering in minutes and seconds is not available in the current version.

I have tried the pre-compiled binary version 1.5 for macOS and Ubuntu version

This is the error I get:

Couldn't read the configuration file: Cannot parse config as TOML. Stork recieved error: unknown variantMinutesAndSeconds, expectednumber_of_secondsfor keyinput.srt_config.timestamp_formatat line 4 column 1

I could only test "timestamp_format = "NumberOfSeconds" successfully. In which version was the "Vimeo format" taken into account?

jameslittle230 commented 1 year ago

@selamhabibi - Good catch. Somehow that made it into the documentation (many months ago) despite the feature having never existed.

In the next release, I'll add this feature, making the documentation correct.

-James

jameslittle230 commented 1 year ago

I've pushed a PR that adds the feature, and I'll publish a release tomorrow that includes it. Thanks again for reporting!